Discussion:
Change in ovirt-engine[master]: core: Avoid starting vm failed if pin to host is removed
(too old to reply)
x***@public.gmane.org
2014-05-28 05:43:12 UTC
Permalink
Xiaolei Shi has uploaded a new change for review.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................

core: Avoid starting vm failed if pin to host is removed

If the vm configured vm numa nodes and pinned them to host numa nodes,
when the host was removed,the pinned host numa nodes would be removed
also. Now if you try to run the vm, it would fail. This patch will
avoid this situation.

Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Bug-Url: https://bugzilla.redhat.com/1101387
Signed-off-by: Bruce Shi <xiao-lei.shi-***@public.gmane.org>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NumaUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
2 files changed, 14 insertions(+), 6 deletions(-)


git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/66/28166/1

diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NumaUtils.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NumaUtils.java
index 0015e4f..b83ddcb 100644
--- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NumaUtils.java
+++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NumaUtils.java
@@ -42,7 +42,7 @@
public static List<Integer> getPinnedNodeIndexList(List<Pair<Guid, Pair<Boolean, Integer>>> nodeList) {
List<Integer> nodeIndexes = new ArrayList<>(nodeList.size());
for (Pair<Guid, Pair<Boolean, Integer>> item : nodeList) {
- if (item.getSecond().getFirst()) {
+ if (item.getSecond().getFirst() && item.getFirst() != null) {
nodeIndexes.add(item.getSecond().getSecond());
}
}
diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
index cbb3b1a..0ec6fc1 100644
--- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
+++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
@@ -196,6 +196,9 @@
}
else {
vmNumaNodePinInfo.addAll(NumaUtils.getPinnedNodeIndexList(node.getVdsNumaNodeList()));
+ if (vmNumaNodePinInfo.isEmpty()) {
+ useAllVdsNodesMem = true;
+ }
}
}
createInfo.put(VdsProperties.VM_NUMA_NODES, createVmNumaNodes);
@@ -215,11 +218,16 @@
NumaUtils.buildStringFromListForNuma(vmNumaNodePinInfo));
}
}
- createInfo.put(VdsProperties.NUMA_TUNE, createNumaTune);
- if (StringUtils.isEmpty(vm.getCpuPinning())) {
- Map<String, Object> cpuPinDict = addCpuPinningForNumaSetting(vmNumaNodes, totalVdsNumaNodes);
- if (!cpuPinDict.isEmpty()) {
- createInfo.put(VdsProperties.cpuPinning, cpuPinDict);
+ if (createNumaTune.containsKey(VdsProperties.NUMA_TUNE_NODESET) &&
+ StringUtils.isNotEmpty((String)createNumaTune.get(VdsProperties.NUMA_TUNE_NODESET))) {
+ createInfo.put(VdsProperties.NUMA_TUNE, createNumaTune);
+ }
+ if (!totalVdsNumaNodes.isEmpty()) {
+ if (StringUtils.isEmpty(vm.getCpuPinning())) {
+ Map<String, Object> cpuPinDict = addCpuPinningForNumaSetting(vmNumaNodes, totalVdsNumaNodes);
+ if (!cpuPinDict.isEmpty()) {
+ createInfo.put(VdsProperties.cpuPinning, cpuPinDict);
+ }
}
}
}
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
a***@public.gmane.org
2014-05-28 05:43:17 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 1:

* #1101387::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-HasComments: No
x***@public.gmane.org
2014-05-28 05:44:18 UTC
Permalink
Xiaolei Shi has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-05-28 05:54:00 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/9144/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/25388/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/8462/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-06-04 06:54:29 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 2:

* #1101387::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
x***@public.gmane.org
2014-06-04 06:57:52 UTC
Permalink
Xiaolei Shi has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-06-04 07:18:21 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 2:

Build Failed

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/8996/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/9677/ : FAILURE

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/25891/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-06-05 02:33:21 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 3:

* Update tracker::#1101387::OK
* Check Bug-Url::OK
* Check Public Bug::#1101387::OK, public bug
* Check Product::#1101387::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-06-05 03:00:01 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/9064/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/9745/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/25959/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
x***@public.gmane.org
2014-06-12 06:06:15 UTC
Permalink
Xiaolei Shi has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-06-12 06:13:22 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 4:

* Update tracker::#1101387::OK
* Check Bug-Url::OK
* Check Public Bug::#1101387::OK, public bug
* Check Product::#1101387::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-06-12 06:37:03 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 4:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/9606/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/26500/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/10292/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-07-15 06:44:48 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 6:

* Update tracker::#1101387::OK
* Check Bug-Url::OK
* Check Public Bug::#1101387::OK, public bug
* Check Product::#1101387::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-07-15 07:17:23 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 6:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/12485/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13156/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/29356/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-07-16 07:25:22 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 7:

* Update tracker::#1101387::OK
* Check Bug-Url::OK
* Check Public Bug::#1101387::OK, public bug
* Check Product::#1101387::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-07-16 07:51:33 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 8:

* Update tracker::#1101387::OK
* Check Bug-Url::OK
* Check Public Bug::#1101387::OK, public bug
* Check Product::#1101387::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-07-16 08:29:06 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 7:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/12582/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13251/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/29451/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-07-16 09:02:58 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 8:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/12597/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13266/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/29466/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-07-21 04:55:40 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 9:

* Update tracker::#1101387::OK
* Check Bug-Url::OK
* Check Public Bug::#1101387::OK, public bug
* Check Product::#1101387::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-07-21 05:25:28 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 9:

Build Failed

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/12822/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13474/ : FAILURE

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/29674/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
ofrenkel-H+wXaHxf7aLQT0dZR+
2014-07-22 15:10:18 UTC
Permalink
Omer Frenkel has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 9: Code-Review+1

Gilad please approve this as well
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-07-24 09:02:05 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 10:

* Update tracker::#1101387::OK
* Check Bug-Url::OK
* Check Public Bug::#1101387::OK, public bug
* Check Product::#1101387::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-07-24 09:32:38 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 10:

Build Failed

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/29979/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13779/ : FAILURE

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/13128/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
gchaplik-H+wXaHxf7aLQT0dZR+
2014-08-11 14:04:52 UTC
Permalink
Gilad Chaplik has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.ovirt.org/#/c/28166/10//COMMIT_MSG
Commit Message:

Line 8:
Line 9: If the vm configured vm numa nodes and pinned them to host numa nodes,
Line 10: when the host was removed,the pinned host numa nodes would be removed
Line 11: also. Now if you try to run the vm, it would fail. This patch will
Line 12: avoid this situation.
sorry for joining in late, I'm trying to understand why delete cascade won't work here?
Line 13:
Line 14: Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Line 15: Bug-Url: https://bugzilla.redhat.com/1101387
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
x***@public.gmane.org
2014-08-12 09:04:29 UTC
Permalink
Xiaolei Shi has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.ovirt.org/#/c/28166/10//COMMIT_MSG
Commit Message:

Line 8:
Line 9: If the vm configured vm numa nodes and pinned them to host numa nodes,
Line 10: when the host was removed,the pinned host numa nodes would be removed
Line 11: also. Now if you try to run the vm, it would fail. This patch will
Line 12: avoid this situation.
Post by gchaplik-H+wXaHxf7aLQT0dZR+
sorry for joining in late, I'm trying to understand why delete cascade won'
Delete cascade works, it will set the pinned node id to null, keep the pinned node index.
In previous codes, it didn't check the id null and will cause a exception, this patch is to fix the issue.
As we talked before, when vm do migration, once the migrated-to host is selected, we will have a action to update the pinned node id, now we don't have this action, so need to add a check here.
Line 13:
Line 14: Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Line 15: Bug-Url: https://bugzilla.redhat.com/1101387
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
a***@public.gmane.org
2014-09-14 14:25:03 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 11:

* Update tracker::#1101387::OK
* Check Bug-Url::OK
* Check Public Bug::#1101387::OK, public bug
* Check Product::#1101387::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-14 14:58:29 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 11:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16122/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/32929/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/16729/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-15 08:06:04 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 12:

* Update tracker::#1101387::OK
* Check Bug-Url::OK
* Check Public Bug::#1101387::OK, public bug
* Check Product::#1101387::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-15 08:44:49 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 12:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16170/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/32977/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/16777/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-16 13:38:00 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 13:

* Update tracker::#1101387::OK
* Check Bug-Url::OK
* Check Public Bug::#1101387::OK, public bug
* Check Product::#1101387::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
rgolan-H+wXaHxf7aLQT0dZR+
2014-09-16 14:04:34 UTC
Permalink
Roy Golan has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 13: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-16 14:38:29 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 13:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16349/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33155/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/16955/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-16 15:40:46 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 14:

* Update tracker::#1101387::OK
* Check Bug-Url::OK
* Check Public Bug::#1101387::OK, public bug
* Check Product::#1101387::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-16 16:02:50 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 14:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16366/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33172/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/16972/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-18 14:33:19 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 15:

* Update tracker::#1101387::OK
* Check Bug-Url::OK
* Check Public Bug::#1101387::OK, public bug
* Check Product::#1101387::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-18 15:05:26 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 15:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16483/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33288/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/17088/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-22 06:57:11 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 16:

* Update tracker::#1101387::OK
* Check Bug-Url::OK
* Check Public Bug::#1101387::OK, public bug
* Check Product::#1101387::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
gchaplik-H+wXaHxf7aLQT0dZR+
2014-09-22 06:59:19 UTC
Permalink
Gilad Chaplik has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 16: Verified+1 Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-22 08:19:09 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 16:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16650/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33454/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/17254/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-22 11:24:34 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 17:

* Update tracker::#1101387::OK
* Check Bug-Url::OK
* Check Public Bug::#1101387::OK, public bug
* Check Product::#1101387::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-22 11:52:26 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 17:

* Update tracker::#1101387::OK
* Check TR::#1101387::ERROR, 3.5.0 should not match .*
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
rgolan-H+wXaHxf7aLQT0dZR+
2014-09-22 11:52:22 UTC
Permalink
Roy Golan has submitted this change and it was merged.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


core: Avoid starting vm failed if pin to host is removed

If the vm configured vm numa nodes and pinned them to host numa nodes,
when the host was removed,the pinned host numa nodes would be removed
also. Now if you try to run the vm, it would fail. This patch will
avoid this situation.

Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Bug-Url: https://bugzilla.redhat.com/1101387
Signed-off-by: Bruce Shi <xiao-lei.shi-***@public.gmane.org>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NumaUtils.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
Gilad Chaplik: Verified; Looks good to me, but someone else must approve
Roy Golan: Looks good to me, approved
Omer Frenkel: Looks good to me, but someone else must approve
Xiaolei Shi: Verified
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server
2014-09-22 12:02:12 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 17:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16702/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33505/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/17305/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-22 12:45:14 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Avoid starting vm failed if pin to host is removed
......................................................................


Patch Set 17:

Build Failed

http://jenkins.ovirt.org/job/ovirt-engine_master_animal-sniffer_merged/8514/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_merged/9567/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_merged/9234/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_merged/4285/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/8892/ : There was an infra issue, please contact infra-***@public.gmane.org
--
To view, visit http://gerrit.ovirt.org/28166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
Continue reading on narkive:
Loading...