Discussion:
Change in ovirt-engine[master]: core: Fix FindBugs filter for XmlNode.innerText
(too old to reply)
amureini-H+wXaHxf7aLQT0dZR+
2013-11-25 09:13:35 UTC
Permalink
Allon Mureinik has uploaded a new change for review.

Change subject: core: Fix FindBugs filter for XmlNode.innerText
......................................................................

core: Fix FindBugs filter for XmlNode.innerText

Commit d377d275416edbbd3f4b1d57047ee04840412bba renamed
XmlNode's InnerText field to innerText, but neglected to update the
FindBugs filter referring to it.

This patch corrects that mistake.

Change-Id: Ibf2e1958319b62ac4fa02c3131614c26233a4ef0
Signed-off-by: Allon Mureinik <amureini-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
---
M backend/manager/modules/compat/exclude-filters.xml
1 file changed, 1 insertion(+), 1 deletion(-)


git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/01/21601/1

diff --git a/backend/manager/modules/compat/exclude-filters.xml b/backend/manager/modules/compat/exclude-filters.xml
index b66881a..0e31b7b 100644
--- a/backend/manager/modules/compat/exclude-filters.xml
+++ b/backend/manager/modules/compat/exclude-filters.xml
@@ -36,7 +36,7 @@
-->
<Match>
<Class name="org.ovirt.engine.core.compat.backendcompat.XmlNode" />
- <Field name="InnerText"/>
+ <Field name="innerText"/>
<Bug code="UrF"/>
</Match>
--
To view, visit http://gerrit.ovirt.org/21601
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf2e1958319b62ac4fa02c3131614c26233a4ef0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
oVirt Jenkins CI Server
2013-11-25 09:15:54 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Fix FindBugs filter for XmlNode.innerText
......................................................................


Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/1669/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/21601
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2e1958319b62ac4fa02c3131614c26233a4ef0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
amureini-H+wXaHxf7aLQT0dZR+
2013-11-25 09:54:14 UTC
Permalink
Allon Mureinik has posted comments on this change.

Change subject: core: Fix FindBugs filter for XmlNode.innerText
......................................................................


Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21601
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2e1958319b62ac4fa02c3131614c26233a4ef0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alissa Bonas <abonas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Allon Mureinik <amureini-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Tal Nisan <tnisan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
tnisan-H+wXaHxf7aLQT0dZR+
2013-11-25 11:21:05 UTC
Permalink
Tal Nisan has posted comments on this change.

Change subject: core: Fix FindBugs filter for XmlNode.innerText
......................................................................


Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21601
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2e1958319b62ac4fa02c3131614c26233a4ef0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alissa Bonas <abonas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Allon Mureinik <amureini-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Tal Nisan <tnisan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
rgolan-H+wXaHxf7aLQT0dZR+
2013-11-25 11:37:39 UTC
Permalink
Roy Golan has posted comments on this change.

Change subject: core: Fix FindBugs filter for XmlNode.innerText
......................................................................


Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21601
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2e1958319b62ac4fa02c3131614c26233a4ef0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alissa Bonas <abonas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Allon Mureinik <amureini-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Tal Nisan <tnisan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
rgolan-H+wXaHxf7aLQT0dZR+
2013-11-25 11:37:41 UTC
Permalink
Roy Golan has submitted this change and it was merged.

Change subject: core: Fix FindBugs filter for XmlNode.innerText
......................................................................


core: Fix FindBugs filter for XmlNode.innerText

Commit d377d275416edbbd3f4b1d57047ee04840412bba renamed
XmlNode's InnerText field to innerText, but neglected to update the
FindBugs filter referring to it.

This patch corrects that mistake.

Change-Id: Ibf2e1958319b62ac4fa02c3131614c26233a4ef0
Signed-off-by: Allon Mureinik <amureini-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
---
M backend/manager/modules/compat/exclude-filters.xml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21601
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf2e1958319b62ac4fa02c3131614c26233a4ef0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alissa Bonas <abonas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Allon Mureinik <amureini-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Tal Nisan <tnisan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server
2013-11-25 11:39:12 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Fix FindBugs filter for XmlNode.innerText
......................................................................


Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/1716/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/21601
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2e1958319b62ac4fa02c3131614c26233a4ef0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alissa Bonas <abonas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Allon Mureinik <amureini-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Tal Nisan <tnisan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2013-11-25 11:40:09 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Fix FindBugs filter for XmlNode.innerText
......................................................................


Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/1718/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/21601
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2e1958319b62ac4fa02c3131614c26233a4ef0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alissa Bonas <abonas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Allon Mureinik <amureini-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Tal Nisan <tnisan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
Continue reading on narkive:
Loading...