Discussion:
Change in ovirt-engine[master]: core: fix numa node distance persist
(too old to reply)
gchaplik-H+wXaHxf7aLQT0dZR+
2014-09-14 14:24:03 UTC
Permalink
Gilad Chaplik has uploaded a new change for review.

Change subject: core: fix numa node distance persist
......................................................................

core: fix numa node distance persist

Persist node distance according to numa index (and
not count).

Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Signed-off-by: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
2 files changed, 22 insertions(+), 8 deletions(-)


git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/01/32901/1

diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java
index bd999ff..94a9ecd 100644
--- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java
+++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java
@@ -6,6 +6,7 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;
+import java.util.Map.Entry;

import org.apache.commons.lang.StringUtils;
import org.ovirt.engine.core.common.businessentities.NumaNodeStatistics;
@@ -200,9 +201,10 @@
if (StringUtils.isBlank(distance)) {
return nodeDistance;
}
- String[] distanceArray = distance.split(",");
+ String[] distanceArray = distance.split(";");
for (int i = 0; i < distanceArray.length; i++) {
- nodeDistance.put(i, Integer.valueOf(distanceArray[i]));
+ String[] nodeDistanceArray = distanceArray[i].split(",");
+ nodeDistance.put(Integer.valueOf(nodeDistanceArray[0]), Integer.valueOf(nodeDistanceArray[1]));
}
return nodeDistance;
}
@@ -212,9 +214,11 @@
return null;
}
StringBuilder sb = new StringBuilder();
- for (int i = 0; i < distance.size(); i++) {
- sb.append(distance.get(i));
+ for (Entry<Integer, Integer> entry : distance.entrySet()) {
+ sb.append(entry.getKey());
sb.append(",");
+ sb.append(entry.getValue());
+ sb.append(";");
}
return sb.deleteCharAt(sb.length() - 1).toString();
}
diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
index 444150d..9eb328a 100644
--- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
+++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
@@ -9,6 +9,7 @@
import java.util.Arrays;
import java.util.Calendar;
import java.util.Collections;
+import java.util.Comparator;
import java.util.Date;
import java.util.HashMap;
import java.util.List;
@@ -1657,12 +1658,21 @@
newNumaNodeList.add(numaNode);
}

- for (Map.Entry<String, Object> item : numaNodeDistanceMap.entrySet()) {
- int index = Integer.valueOf(item.getKey());
- List<Integer> distances = extractIntegerList(numaNodeDistanceMap, item.getKey());
+ Collections.sort(newNumaNodeList, new Comparator<VdsNumaNode>() {
+
+ @Override
+ public int compare(VdsNumaNode arg0, VdsNumaNode arg1) {
+ return arg0.getIndex() < arg1.getIndex() ? -1 : 1;
+ }
+
+ });
+
+ for (VdsNumaNode vdsNumaNode : newNumaNodeList) {
+ int index = vdsNumaNode.getIndex();
+ List<Integer> distances = extractIntegerList(numaNodeDistanceMap, String.valueOf(index));
Map<Integer, Integer> distanceMap = new HashMap<>(distances.size());
for (int i = 0; i < distances.size(); i++) {
- distanceMap.put(i, distances.get(i));
+ distanceMap.put(newNumaNodeList.get(i).getIndex(), distances.get(i));
}
VdsNumaNode newNumaNode = NumaUtils.getVdsNumaNodeByIndex(newNumaNodeList, index);
if (newNumaNode != null) {
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
a***@public.gmane.org
2014-09-14 14:25:26 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-14 15:05:01 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4711/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16126/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/32933/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/16733/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-15 08:05:23 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-15 08:26:49 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 2:

Build Failed

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4719/ : FAILURE

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16160/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/32967/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/16767/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-16 13:36:50 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 3:

* Update tracker::#1069303::OK
* Check Bug-Url::OK
* Check Public Bug::#1069303::OK, public bug
* Check Product::#1069303::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-16 14:07:11 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 3:

Build Failed

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4764/ : FAILURE

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16339/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33145/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/16945/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-16 15:40:00 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 4:

* Update tracker::#1069303::OK
* Check Bug-Url::OK
* Check Public Bug::#1069303::OK, public bug
* Check Product::#1069303::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-16 16:13:54 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 4:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4773/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16360/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33166/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/16966/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-17 13:47:17 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 5:

* Update tracker::#1069303::OK
* Check Bug-Url::OK
* Check Public Bug::#1069303::OK, public bug
* Check Product::#1069303::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-17 14:25:09 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 5:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4792/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16406/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33211/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/17011/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
rgolan-H+wXaHxf7aLQT0dZR+
2014-09-18 08:27:16 UTC
Permalink
Roy Golan has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 5:

(4 comments)

http://gerrit.ovirt.org/#/c/32901/5/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java
File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java:

Line 195: return new Pair<Guid, Integer>(getGuid(rs, "numa_node_id"), rs.getInt("cpu_core_id"));
Line 196: }
Line 197: };
Line 198:
Line 199: private static Map<Integer, Integer> getDistanceMap(String distance) {
please comment the parsing scheme
Line 200: Map<Integer, Integer> nodeDistance = new HashMap<>();
Line 201: if (StringUtils.isBlank(distance)) {
Line 202: return nodeDistance;
Line 203: }


Line 203: }
Line 204: String[] distanceArray = distance.split(";");
Line 205: for (int i = 0; i < distanceArray.length; i++) {
Line 206: String[] nodeDistanceArray = distanceArray[i].split(",");
Line 207: nodeDistance.put(Integer.valueOf(nodeDistanceArray[0]), Integer.valueOf(nodeDistanceArray[1]));
you keep putting in under the same key?
Line 208: }
Line 209: return nodeDistance;
Line 210: }
Line 211:


http://gerrit.ovirt.org/#/c/32901/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java:

Line 1657: numaNode.setMemTotal(memTotal);
Line 1658: newNumaNodeList.add(numaNode);
Line 1659: }
Line 1660:
Line 1661: Collections.sort(newNumaNodeList, new Comparator<VdsNumaNode>() {
any reason the NumaNode couldn't implement Comparator and we could also save the instance creation?

and the code would be

Collections.sort(list)
Line 1662:
Line 1663: @Override
Line 1664: public int compare(VdsNumaNode arg0, VdsNumaNode arg1) {
Line 1665: return arg0.getIndex() < arg1.getIndex() ? -1 : 1;


Line 1671: int index = vdsNumaNode.getIndex();
Line 1672: List<Integer> distances = extractIntegerList(numaNodeDistanceMap, String.valueOf(index));
Line 1673: Map<Integer, Integer> distanceMap = new HashMap<>(distances.size());
Line 1674: for (int i = 0; i < distances.size(); i++) {
Line 1675: distanceMap.put(newNumaNodeList.get(i).getIndex(), distances.get(i));
could you change that to regular java foreach?
Line 1676: }
Line 1677: VdsNumaNode newNumaNode = NumaUtils.getVdsNumaNodeByIndex(newNumaNodeList, index);
Line 1678: if (newNumaNode != null) {
Line 1679: newNumaNode.setNumaNodeDistances(distanceMap);
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
a***@public.gmane.org
2014-09-18 14:32:22 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 6:

* Update tracker::#1069303::OK
* Check Bug-Url::OK
* Check Public Bug::#1069303::OK, public bug
* Check Product::#1069303::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-18 14:54:24 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 6:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4816/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16473/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33278/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/17078/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-22 06:56:41 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 7:

* Update tracker::#1069303::OK
* Check Bug-Url::OK
* Check Public Bug::#1069303::OK, public bug
* Check Product::#1069303::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
gchaplik-H+wXaHxf7aLQT0dZR+
2014-09-22 07:00:59 UTC
Permalink
Gilad Chaplik has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-22 07:57:26 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 7:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4860/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16645/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33449/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/17249/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-22 11:24:02 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 8:

* Update tracker::#1069303::OK
* Check Bug-Url::OK
* Check Public Bug::#1069303::OK, public bug
* Check Product::#1069303::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-22 11:36:19 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 8: Code-Review-1 Verified-1

Build Failed

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4875/ : FAILURE

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16697/ : The patch does not pass the findbugs

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33500/ : The patch did not pass the checkstyle, please fix

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/17300/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-22 11:37:45 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 9:

* Update tracker::#1069303::OK
* Check Bug-Url::OK
* Check Public Bug::#1069303::OK, public bug
* Check Product::#1069303::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
rgolan-H+wXaHxf7aLQT0dZR+
2014-09-22 11:39:32 UTC
Permalink
Roy Golan has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-22 11:44:06 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 10:

* Update tracker::#1069303::OK
* Check Bug-Url::OK
* Check Public Bug::#1069303::OK, public bug
* Check Product::#1069303::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
gchaplik-H+wXaHxf7aLQT0dZR+
2014-09-22 11:50:38 UTC
Permalink
Gilad Chaplik has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 10: Verified+1
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-22 12:02:32 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 10:

* Update tracker::#1069303::OK
* Set MODIFIED::bug 1069303::::#1069303::::IGNORE, not all related patches are closed, check 32903
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
rgolan-H+wXaHxf7aLQT0dZR+
2014-09-22 12:02:25 UTC
Permalink
Roy Golan has submitted this change and it was merged.

Change subject: core: fix numa node distance persist
......................................................................


core: fix numa node distance persist

Persist node distance according to numa index (and
not count).

Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Bug-Url: https://bugzilla.redhat.com/1069303
Signed-off-by: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
2 files changed, 25 insertions(+), 8 deletions(-)

Approvals:
Gilad Chaplik: Verified
Roy Golan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server
2014-09-22 12:55:00 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 9:

Build Failed

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4883/ : FAILURE

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16711/ : The patch does not pass the findbugs

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33514/ : The patch did not pass the checkstyle, please fix

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/17314/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-22 13:22:35 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 10:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4884/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16715/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33518/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/17318/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-22 13:50:30 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: fix numa node distance persist
......................................................................


Patch Set 10:

Build Failed

http://jenkins.ovirt.org/job/ovirt-engine_master_animal-sniffer_merged/8518/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_merged/9571/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_merged/9238/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_merged/4289/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/8896/ : There was an infra issue, please contact infra-***@public.gmane.org
--
To view, visit http://gerrit.ovirt.org/32901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
Continue reading on narkive:
Loading...