Discussion:
Change in ovirt-engine[master]: utils: introduce universal utilities (uutils)
(too old to reply)
a***@public.gmane.org
2014-04-19 19:42:44 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-HasComments: No
Alon Bar-Lev
2014-04-19 19:42:43 UTC
Permalink
Alon Bar-Lev has uploaded a new change for review.

Change subject: utils: introduce universal utilities (uutils)
......................................................................

utils: introduce universal utilities (uutils)

a package of packages that may be split out of engine, not directly
related to engine and can be split even to own jars.

this will enable components that should not pull the engine 'common'
part to enjoy these utilities.

Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Signed-off-by: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
---
M Makefile
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHClient.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHDialog.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java
M backend/manager/modules/builtin-extensions/pom.xml
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsArguments.java
M backend/manager/modules/builtin-extensions/src/main/modules/org/ovirt/engine/extensions/builtin/main/module.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java
M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml
A backend/manager/modules/uutils/exclude-filters.xml
A backend/manager/modules/uutils/pom.xml
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/Argument.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/ArgumentBuilder.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/ExtendedCliParser.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ConstraintByteArrayOutputStream.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressInputStream.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressOutputStream.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHClient.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHDialog.java
A backend/manager/modules/uutils/src/main/modules/org/ovirt/engine/core/uutils/main/module.xml
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/cli/ArgumentBuilderTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/cli/ExtendedCliParserTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/BasicTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/CommandTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/ConstraintByteArrayOutputStreamTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtilsTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/PropertiesTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHD.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHDialogTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TimeoutTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TransferTest.java
A backend/manager/modules/uutils/src/test/resources/key.p12
M backend/manager/tools/src/main/modules/org/ovirt/engine/core/tools/main/module.xml
M ear/src/main/resources/META-INF/MANIFEST.MF
M ovirt-engine.spec.in
43 files changed, 182 insertions(+), 61 deletions(-)


git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/24/26924/1

diff --git a/Makefile b/Makefile
index 6fb4748..b9567c3 100644
--- a/Makefile
+++ b/Makefile
@@ -355,6 +355,7 @@
install -m 644 backend/manager/modules/scheduler/pom.xml "$(DESTDIR)$(MAVENPOM_DIR)/$(PACKAGE_NAME)-scheduler.pom"
install -m 644 backend/manager/modules/searchbackend/pom.xml "$(DESTDIR)$(MAVENPOM_DIR)/$(PACKAGE_NAME)-searchbackend.pom"
install -m 644 backend/manager/modules/utils/pom.xml "$(DESTDIR)$(MAVENPOM_DIR)/$(PACKAGE_NAME)-utils.pom"
+ install -m 644 backend/manager/modules/uutils/pom.xml "$(DESTDIR)$(MAVENPOM_DIR)/$(PACKAGE_NAME)-uutils.pom"
install -m 644 backend/manager/modules/vdsbroker/pom.xml "$(DESTDIR)$(MAVENPOM_DIR)/$(PACKAGE_NAME)-vdsbroker.pom"
install -m 644 backend/manager/pom.xml "$(DESTDIR)$(MAVENPOM_DIR)/$(PACKAGE_NAME)-manager.pom"
install -m 644 backend/manager/tools/pom.xml "$(DESTDIR)$(MAVENPOM_DIR)/$(PACKAGE_NAME)-tools.pom"
diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
index 36a05c0..c200bc2 100644
--- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
+++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
@@ -50,11 +50,11 @@
import org.ovirt.engine.core.dal.job.ExecutionMessageDirector;
import org.ovirt.engine.core.dao.gluster.GlusterDBUtils;
import org.ovirt.engine.core.utils.crypt.EngineEncryptionUtils;
-import org.ovirt.engine.core.utils.ssh.ConstraintByteArrayOutputStream;
-import org.ovirt.engine.core.utils.ssh.SSHClient;
import org.ovirt.engine.core.utils.threadpool.ThreadPoolUtil;
import org.ovirt.engine.core.utils.transaction.TransactionMethod;
import org.ovirt.engine.core.utils.transaction.TransactionSupport;
+import org.ovirt.engine.core.uutils.ssh.ConstraintByteArrayOutputStream;
+import org.ovirt.engine.core.uutils.ssh.SSHClient;

@NonTransactiveCommandAttribute(forceCompensation = true)
public class AddVdsCommand<T extends AddVdsActionParameters> extends VdsCommand<T> {
diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java
index e6b4d2d..c9fcd4e 100644
--- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java
+++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java
@@ -17,7 +17,7 @@
import org.ovirt.engine.core.common.config.ConfigValues;
import org.ovirt.engine.core.utils.log.Log;
import org.ovirt.engine.core.utils.log.LogFactory;
-import org.ovirt.engine.core.utils.ssh.SSHDialog;
+import org.ovirt.engine.core.uutils.ssh.SSHDialog;

/**
* ovirt-node upgrade.
diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
index 53101e9..201c3ee 100644
--- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
+++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
@@ -45,9 +45,9 @@
import org.ovirt.engine.core.utils.linq.Predicate;
import org.ovirt.engine.core.utils.log.Log;
import org.ovirt.engine.core.utils.log.LogFactory;
-import org.ovirt.engine.core.utils.ssh.SSHDialog;
import org.ovirt.engine.core.utils.transaction.TransactionMethod;
import org.ovirt.engine.core.utils.transaction.TransactionSupport;
+import org.ovirt.engine.core.uutils.ssh.SSHDialog;
import org.ovirt.otopi.constants.BaseEnv;
import org.ovirt.otopi.constants.Confirms;
import org.ovirt.otopi.constants.CoreEnv;
diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHClient.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHClient.java
index b5dc928..4e18c44 100644
--- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHClient.java
+++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHClient.java
@@ -14,8 +14,8 @@
import org.ovirt.engine.core.dal.dbbroker.DbFacade;

import org.ovirt.engine.core.utils.crypt.EngineEncryptionUtils;
-import org.ovirt.engine.core.utils.crypt.OpenSSHUtils;
-import org.ovirt.engine.core.utils.ssh.SSHClient;
+import org.ovirt.engine.core.uutils.ssh.OpenSSHUtils;
+import org.ovirt.engine.core.uutils.ssh.SSHClient;

/**
* SSH client to be used with engine defaults
diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHDialog.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHDialog.java
index cef1f73..1de57bd 100644
--- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHDialog.java
+++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHDialog.java
@@ -7,10 +7,10 @@

import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
-import org.ovirt.engine.core.utils.crypt.EngineEncryptionUtils;
-import org.ovirt.engine.core.utils.ssh.SSHClient;
-import org.ovirt.engine.core.utils.ssh.SSHDialog;
import org.ovirt.engine.core.common.businessentities.VDS;
+import org.ovirt.engine.core.utils.crypt.EngineEncryptionUtils;
+import org.ovirt.engine.core.uutils.ssh.SSHClient;
+import org.ovirt.engine.core.uutils.ssh.SSHDialog;

/**
* SSH dialog to be used with engine defaults
diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java
index 508a114..eeb2461 100644
--- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java
+++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java
@@ -37,8 +37,8 @@
import org.ovirt.engine.core.utils.lock.LockManagerFactory;
import org.ovirt.engine.core.utils.log.Log;
import org.ovirt.engine.core.utils.log.LogFactory;
-import org.ovirt.engine.core.utils.ssh.ConstraintByteArrayOutputStream;
-import org.ovirt.engine.core.utils.ssh.SSHClient;
+import org.ovirt.engine.core.uutils.ssh.ConstraintByteArrayOutputStream;
+import org.ovirt.engine.core.uutils.ssh.SSHClient;
import org.w3c.dom.Element;
import org.w3c.dom.Node;
import org.w3c.dom.NodeList;
diff --git a/backend/manager/modules/builtin-extensions/pom.xml b/backend/manager/modules/builtin-extensions/pom.xml
index fbc60fb..d5a5947 100644
--- a/backend/manager/modules/builtin-extensions/pom.xml
+++ b/backend/manager/modules/builtin-extensions/pom.xml
@@ -32,6 +32,11 @@
</dependency>
<dependency>
<groupId>${engine.groupId}</groupId>
+ <artifactId>uutils</artifactId>
+ <version>${engine.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>${engine.groupId}</groupId>
<artifactId>aaa</artifactId>
<version>${engine.version}</version>
</dependency>
diff --git a/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsArguments.java b/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsArguments.java
index 5fbcceb..59c570e 100644
--- a/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsArguments.java
+++ b/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsArguments.java
@@ -11,8 +11,8 @@
import org.apache.commons.lang.StringUtils;
import org.ovirt.engine.core.ldap.LdapProviderType;
import org.ovirt.engine.core.utils.EngineLocalConfig;
-import org.ovirt.engine.core.utils.cli.ArgumentBuilder;
-import org.ovirt.engine.core.utils.cli.ExtendedCliParser;
+import org.ovirt.engine.core.uutils.cli.ArgumentBuilder;
+import org.ovirt.engine.core.uutils.cli.ExtendedCliParser;

/**
* Class for command line arguments parsing and validation
diff --git a/backend/manager/modules/builtin-extensions/src/main/modules/org/ovirt/engine/extensions/builtin/main/module.xml b/backend/manager/modules/builtin-extensions/src/main/modules/org/ovirt/engine/extensions/builtin/main/module.xml
index c62b7fa..0f492d8 100644
--- a/backend/manager/modules/builtin-extensions/src/main/modules/org/ovirt/engine/extensions/builtin/main/module.xml
+++ b/backend/manager/modules/builtin-extensions/src/main/modules/org/ovirt/engine/extensions/builtin/main/module.xml
@@ -18,6 +18,7 @@
<module name="org.ovirt.engine.core.common"/>
<module name="org.ovirt.engine.core.compat"/>
<module name="org.ovirt.engine.core.utils"/>
+ <module name="org.ovirt.engine.core.uutils"/>
<module name="org.springframework"/>
<module name="sun.jdk"/>

diff --git a/backend/manager/modules/pom.xml b/backend/manager/modules/pom.xml
index 8417fbf..d4938c8 100644
--- a/backend/manager/modules/pom.xml
+++ b/backend/manager/modules/pom.xml
@@ -16,6 +16,7 @@

<modules>
<module>extensions-api-root</module>
+ <module>uutils</module>
<module>compat</module>
<module>utils</module>
<module>common</module>
diff --git a/backend/manager/modules/utils/pom.xml b/backend/manager/modules/utils/pom.xml
index daf3b1c..736f01f 100644
--- a/backend/manager/modules/utils/pom.xml
+++ b/backend/manager/modules/utils/pom.xml
@@ -30,18 +30,6 @@
</dependency>

<dependency>
- <groupId>org.apache.mina</groupId>
- <artifactId>mina-core</artifactId>
- <version>${mina-core.version}</version>
- </dependency>
-
- <dependency>
- <groupId>org.apache.sshd</groupId>
- <artifactId>sshd-core</artifactId>
- <version>${sshd-core.version}</version>
- </dependency>
-
- <dependency>
<groupId>org.ovirt.otopi</groupId>
<artifactId>otopi</artifactId>
<version>${otopi.version}</version>
@@ -56,6 +44,12 @@
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-compress</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>${engine.groupId}</groupId>
+ <artifactId>uutils</artifactId>
+ <version>${engine.version}</version>
</dependency>

<dependency>
@@ -172,9 +166,6 @@
<additionalClasspathElements>
<additionalClasspathElement>${basedir}/src/test/java</additionalClasspathElement>
</additionalClasspathElements>
- <excludes>
- <exclude>**/ssh/*.java</exclude>
- </excludes>
</configuration>
</plugin>

@@ -186,13 +177,6 @@
</plugins>
</build>
<profiles>
- <profile>
- <id>enable-ssh-tests</id>
- <properties>
- <test>**/ssh/*.java</test>
- </properties>
- </profile>
-
<profile>
<id>findbugs</id>
<activation>
diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java
index 0263801..ff028b7 100644
--- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java
+++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java
@@ -11,7 +11,7 @@

import org.apache.commons.codec.binary.Base64;

-import org.ovirt.engine.core.utils.crypt.OpenSSHUtils;
+import org.ovirt.engine.core.uutils.ssh.OpenSSHUtils;

public class PKIResources {

diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java
index 30a962c..279e90b 100644
--- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java
+++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java
@@ -19,6 +19,7 @@
import org.ovirt.engine.core.common.config.Config;
import org.ovirt.engine.core.common.config.ConfigValues;
import org.ovirt.engine.core.utils.EngineLocalConfig;
+import org.ovirt.engine.core.uutils.ssh.OpenSSHUtils;

public class EngineEncryptionUtils {

diff --git a/backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml b/backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml
index d1c12ae..33b75f0 100644
--- a/backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml
+++ b/backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml
@@ -19,12 +19,12 @@
<module name="org.apache.commons.lang"/>
<module name="org.apache.commons.logging"/>
<module name="org.apache.log4j"/>
- <module name="org.apache.sshd"/>
<module name="org.codehaus.jackson.jackson-core-asl"/>
<module name="org.codehaus.jackson.jackson-mapper-asl"/>
<module name="org.ovirt.engine.core.common"/>
<module name="org.ovirt.engine.core.compat"/>
<module name="org.ovirt.engine.core.dal"/>
+ <module name="org.ovirt.engine.core.uutils"/>
<module name="org.infinispan"/>
<module name="org.springframework"/>
<module name="org.postgresql"/>
diff --git a/backend/manager/modules/uutils/exclude-filters.xml b/backend/manager/modules/uutils/exclude-filters.xml
new file mode 100644
index 0000000..43bc332
--- /dev/null
+++ b/backend/manager/modules/uutils/exclude-filters.xml
@@ -0,0 +1,2 @@
+<FindBugsFilter>
+</FindBugsFilter>
diff --git a/backend/manager/modules/uutils/pom.xml b/backend/manager/modules/uutils/pom.xml
new file mode 100644
index 0000000..6e6db23
--- /dev/null
+++ b/backend/manager/modules/uutils/pom.xml
@@ -0,0 +1,106 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.ovirt.engine.core</groupId>
+ <artifactId>manager-modules</artifactId>
+ <version>3.5.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>uutils</artifactId>
+ <packaging>jar</packaging>
+
+ <name>Universal utilities</name>
+
+ <dependencies>
+
+ <dependency>
+ <groupId>org.apache.sshd</groupId>
+ <artifactId>sshd-core</artifactId>
+ <version>${sshd-core.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>commons-lang</groupId>
+ <artifactId>commons-lang</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>commons-codec</groupId>
+ <artifactId>commons-codec</artifactId>
+ </dependency>
+
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <additionalClasspathElements>
+ <additionalClasspathElement>${basedir}/src/test/java</additionalClasspathElement>
+ </additionalClasspathElements>
+ <excludes>
+ <exclude>**/ssh/*.java</exclude>
+ </excludes>
+ </configuration>
+ </plugin>
+
+ <!-- Create the JBoss module: -->
+ <plugin>
+ <groupId>org.ovirt.engine</groupId>
+ <artifactId>jboss-modules-maven-plugin</artifactId>
+ </plugin>
+ </plugins>
+ </build>
+ <profiles>
+ <profile>
+ <id>enable-ssh-tests</id>
+ <properties>
+ <test>**/ssh/*.java</test>
+ </properties>
+ </profile>
+
+ <profile>
+ <id>findbugs</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>findbugs-maven-plugin</artifactId>
+ <version>${findbugs.version}</version>
+ <configuration>
+ <xmlOutput>true</xmlOutput>
+ <!-- Optional directory to put findbugs xdoc xml report -->
+ <excludeFilterFile> ${basedir}/exclude-filters.xml</excludeFilterFile>
+ <xmlOutputDirectory>target/site</xmlOutputDirectory>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+
+ <profile>
+ <id>findbugs-general</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>findbugs-maven-plugin</artifactId>
+ <version>${findbugs.version}</version>
+ <configuration>
+ <xmlOutput>true</xmlOutput>
+ <!-- Optional directory to put findbugs xdoc xml report -->
+ <excludeFilterFile> ${basedir}/exclude-filters.xml, ${basedir}/../../../../exclude-filters-general.xml</excludeFilterFile>
+ <xmlOutputDirectory>target/site</xmlOutputDirectory>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ </profiles>
+
+</project>
diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cli/Argument.java b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/Argument.java
similarity index 94%
rename from backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cli/Argument.java
rename to backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/Argument.java
index 4d15785..760cbef 100644
--- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cli/Argument.java
+++ b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/Argument.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.cli;
+package org.ovirt.engine.core.uutils.cli;

/**
* Represents argument specification inside {@link ExtendedCliParser}
diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cli/ArgumentBuilder.java b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/ArgumentBuilder.java
similarity index 97%
rename from backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cli/ArgumentBuilder.java
rename to backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/ArgumentBuilder.java
index 1215973..b1dee48 100644
--- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cli/ArgumentBuilder.java
+++ b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/ArgumentBuilder.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.cli;
+package org.ovirt.engine.core.uutils.cli;

import org.apache.commons.lang.StringUtils;

diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cli/ExtendedCliParser.java b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/ExtendedCliParser.java
similarity index 99%
rename from backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cli/ExtendedCliParser.java
rename to backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/ExtendedCliParser.java
index 79e172f..9f55994 100644
--- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cli/ExtendedCliParser.java
+++ b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/ExtendedCliParser.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.cli;
+package org.ovirt.engine.core.uutils.cli;

import java.util.HashMap;
import java.util.Map;
diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ConstraintByteArrayOutputStream.java b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ConstraintByteArrayOutputStream.java
similarity index 95%
rename from backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ConstraintByteArrayOutputStream.java
rename to backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ConstraintByteArrayOutputStream.java
index a4601db..c6302c5 100644
--- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ConstraintByteArrayOutputStream.java
+++ b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ConstraintByteArrayOutputStream.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.ssh;
+package org.ovirt.engine.core.uutils.ssh;

import java.io.ByteArrayOutputStream;

diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/OpenSSHUtils.java b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java
similarity index 98%
rename from backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/OpenSSHUtils.java
rename to backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java
index ff7cc6e..0820685 100644
--- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/OpenSSHUtils.java
+++ b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.crypt;
+package org.ovirt.engine.core.uutils.ssh;

import java.io.ByteArrayOutputStream;
import java.io.DataOutputStream;
diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ProgressInputStream.java b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressInputStream.java
similarity index 95%
rename from backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ProgressInputStream.java
rename to backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressInputStream.java
index efa3919..620c4cc 100644
--- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ProgressInputStream.java
+++ b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressInputStream.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.ssh;
+package org.ovirt.engine.core.uutils.ssh;

import java.io.FilterInputStream;
import java.io.IOException;
diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ProgressOutputStream.java b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressOutputStream.java
similarity index 94%
rename from backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ProgressOutputStream.java
rename to backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressOutputStream.java
index 4b64575..6f4d46e 100644
--- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ProgressOutputStream.java
+++ b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressOutputStream.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.ssh;
+package org.ovirt.engine.core.uutils.ssh;

import java.io.FilterOutputStream;
import java.io.IOException;
diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHClient.java
similarity index 99%
rename from backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java
rename to backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHClient.java
index 9c9026b..860678f 100644
--- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java
+++ b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHClient.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.ssh;
+package org.ovirt.engine.core.uutils.ssh;

import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHDialog.java
similarity index 99%
rename from backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java
rename to backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHDialog.java
index 4abab39..6a32f80 100644
--- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java
+++ b/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHDialog.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.ssh;
+package org.ovirt.engine.core.uutils.ssh;

import java.io.ByteArrayOutputStream;
import java.io.Closeable;
diff --git a/backend/manager/modules/uutils/src/main/modules/org/ovirt/engine/core/uutils/main/module.xml b/backend/manager/modules/uutils/src/main/modules/org/ovirt/engine/core/uutils/main/module.xml
new file mode 100644
index 0000000..c8b8b95
--- /dev/null
+++ b/backend/manager/modules/uutils/src/main/modules/org/ovirt/engine/core/uutils/main/module.xml
@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<module xmlns="urn:jboss:module:1.1" name="org.ovirt.engine.core.uutils">
+
+ <resources>
+ <resource-root path="uutils.jar"/>
+ </resources>
+
+ <dependencies>
+ <module name="javax.api"/>
+ <module name="org.apache.commons.codec"/>
+ <module name="org.apache.commons.lang"/>
+ <module name="org.apache.commons.logging"/>
+ <module name="org.apache.sshd"/>
+ </dependencies>
+
+</module>
diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/cli/ArgumentBuilderTest.java b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/cli/ArgumentBuilderTest.java
similarity index 98%
rename from backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/cli/ArgumentBuilderTest.java
rename to backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/cli/ArgumentBuilderTest.java
index f2d72a3..cff4c92 100644
--- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/cli/ArgumentBuilderTest.java
+++ b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/cli/ArgumentBuilderTest.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.cli;
+package org.ovirt.engine.core.uutils.cli;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/cli/ExtendedCliParserTest.java b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/cli/ExtendedCliParserTest.java
similarity index 98%
rename from backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/cli/ExtendedCliParserTest.java
rename to backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/cli/ExtendedCliParserTest.java
index 1a23912..50599c5 100644
--- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/cli/ExtendedCliParserTest.java
+++ b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/cli/ExtendedCliParserTest.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.cli;
+package org.ovirt.engine.core.uutils.cli;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
@@ -6,7 +6,7 @@
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
-import static org.ovirt.engine.core.utils.cli.ExtendedCliParser.VALUE_SEP_LONG;
+import static org.ovirt.engine.core.uutils.cli.ExtendedCliParser.VALUE_SEP_LONG;

import java.util.Map;

diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/BasicTest.java b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/BasicTest.java
similarity index 98%
rename from backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/BasicTest.java
rename to backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/BasicTest.java
index 668e0a0..4781d73 100644
--- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/BasicTest.java
+++ b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/BasicTest.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.ssh;
+package org.ovirt.engine.core.uutils.ssh;

import static org.junit.Assert.assertEquals;

diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/CommandTest.java b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/CommandTest.java
similarity index 98%
rename from backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/CommandTest.java
rename to backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/CommandTest.java
index f9f7ae0..8b207e7 100644
--- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/CommandTest.java
+++ b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/CommandTest.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.ssh;
+package org.ovirt.engine.core.uutils.ssh;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/ConstraintByteArrayOutputStreamTest.java b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/ConstraintByteArrayOutputStreamTest.java
similarity index 93%
rename from backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/ConstraintByteArrayOutputStreamTest.java
rename to backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/ConstraintByteArrayOutputStreamTest.java
index bb42d6d..f39fdb7 100644
--- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/ConstraintByteArrayOutputStreamTest.java
+++ b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/ConstraintByteArrayOutputStreamTest.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.ssh;
+package org.ovirt.engine.core.uutils.ssh;

import static org.junit.Assert.assertTrue;

diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/crypt/OpenSSHUtilsTest.java b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtilsTest.java
similarity index 99%
rename from backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/crypt/OpenSSHUtilsTest.java
rename to backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtilsTest.java
index 016d968..a648678 100644
--- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/crypt/OpenSSHUtilsTest.java
+++ b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtilsTest.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.crypt;
+package org.ovirt.engine.core.uutils.ssh;

import static org.junit.Assert.assertEquals;

diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/PropertiesTest.java b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/PropertiesTest.java
similarity index 95%
rename from backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/PropertiesTest.java
rename to backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/PropertiesTest.java
index 84b0fd8..65ce7e3 100644
--- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/PropertiesTest.java
+++ b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/PropertiesTest.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.ssh;
+package org.ovirt.engine.core.uutils.ssh;

import java.io.IOException;

diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHD.java b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHD.java
similarity index 98%
rename from backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHD.java
rename to backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHD.java
index efbc70f..b7319bb 100644
--- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHD.java
+++ b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHD.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.ssh;
+package org.ovirt.engine.core.uutils.ssh;

import java.io.IOException;
import java.security.KeyPair;
diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHDialogTest.java
similarity index 98%
rename from backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java
rename to backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHDialogTest.java
index 3e85e7e..3445279 100644
--- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java
+++ b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHDialogTest.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.ssh;
+package org.ovirt.engine.core.uutils.ssh;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
@@ -32,8 +32,6 @@
import org.junit.Test;

import org.apache.commons.lang.SystemUtils;
-
-import org.ovirt.engine.core.utils.crypt.OpenSSHUtils;

/*
* Test properties
diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TestCommon.java b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java
similarity index 98%
rename from backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TestCommon.java
rename to backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java
index 7be04d6..d8beaef 100644
--- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TestCommon.java
+++ b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.ssh;
+package org.ovirt.engine.core.uutils.ssh;

/*
* Example of execution:
diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TimeoutTest.java b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TimeoutTest.java
similarity index 98%
rename from backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TimeoutTest.java
rename to backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TimeoutTest.java
index 04b8914..5143024 100644
--- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TimeoutTest.java
+++ b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TimeoutTest.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.ssh;
+package org.ovirt.engine.core.uutils.ssh;

import static org.mockito.Matchers.anyInt;
import static org.mockito.Matchers.anyLong;
diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TransferTest.java b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TransferTest.java
similarity index 98%
rename from backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TransferTest.java
rename to backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TransferTest.java
index f006092..c62ca1c 100644
--- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TransferTest.java
+++ b/backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TransferTest.java
@@ -1,4 +1,4 @@
-package org.ovirt.engine.core.utils.ssh;
+package org.ovirt.engine.core.uutils.ssh;

import static org.junit.Assert.assertArrayEquals;

diff --git a/backend/manager/modules/uutils/src/test/resources/key.p12 b/backend/manager/modules/uutils/src/test/resources/key.p12
new file mode 100644
index 0000000..2ee9979
--- /dev/null
+++ b/backend/manager/modules/uutils/src/test/resources/key.p12
Binary files differ
diff --git a/backend/manager/tools/src/main/modules/org/ovirt/engine/core/tools/main/module.xml b/backend/manager/tools/src/main/modules/org/ovirt/engine/core/tools/main/module.xml
index 3f5fa07..47de050 100644
--- a/backend/manager/tools/src/main/modules/org/ovirt/engine/core/tools/main/module.xml
+++ b/backend/manager/tools/src/main/modules/org/ovirt/engine/core/tools/main/module.xml
@@ -17,6 +17,7 @@
<module name="org.ovirt.engine.core.common"/>
<module name="org.ovirt.engine.core.compat"/>
<module name="org.ovirt.engine.core.utils"/>
+ <module name="org.ovirt.engine.core.uutils"/>
<module name="org.postgresql"/>
<module name="org.snmp4j"/>
<module name="sun.jdk"/>
diff --git a/ear/src/main/resources/META-INF/MANIFEST.MF b/ear/src/main/resources/META-INF/MANIFEST.MF
index 28e6f0a..4a982d6 100644
--- a/ear/src/main/resources/META-INF/MANIFEST.MF
+++ b/ear/src/main/resources/META-INF/MANIFEST.MF
@@ -19,6 +19,7 @@
org.ovirt.engine.core.dal,
org.ovirt.engine.core.searchbackend,
org.ovirt.engine.core.utils,
+ org.ovirt.engine.core.uutils,
org.ovirt.otopi,
org.ovirt.ovirt-host-deploy,
org.ovirt.engine.core.aaa,
diff --git a/ovirt-engine.spec.in b/ovirt-engine.spec.in
index 3777ce4..4c93c57 100644
--- a/ovirt-engine.spec.in
+++ b/ovirt-engine.spec.in
@@ -586,6 +586,7 @@
%{engine_jboss_modules}/org/ovirt/engine/core/searchbackend/main/searchbackend.jar
%{engine_jboss_modules}/org/ovirt/engine/core/tools/main/tools.jar
%{engine_jboss_modules}/org/ovirt/engine/core/utils/main/utils.jar
+%{engine_jboss_modules}/org/ovirt/engine/core/uutils/main/uutils.jar
%{engine_jboss_modules}/org/ovirt/engine/extensions/builtin/main/builtin.jar
%{engine_restapi_war}/WEB-INF/lib/interface-common-jaxrs.jar
%{engine_restapi_war}/WEB-INF/lib/restapi-definition.jar
@@ -791,6 +792,7 @@
%{engine_java}/extensions-manager.jar
%{engine_java}/ovirt-engine-extensions-api.jar
%{engine_java}/utils.jar
+%{engine_java}/uutils.jar

#
# ATTENTION:
@@ -807,6 +809,7 @@
%{_mavenpomdir}/JPP.%{name}-common.pom
%{_mavenpomdir}/JPP.%{name}-compat.pom
%{_mavenpomdir}/JPP.%{name}-utils.pom
+%{_mavenpomdir}/JPP.%{name}-uutils.pom
%endif

%files lib
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Alon Bar-Lev
2014-04-19 19:44:49 UTC
Permalink
Alon Bar-Lev has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 1:

yair, what do you think?
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-04-19 19:47:51 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/5893/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/22138/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
yzaslavs-H+wXaHxf7aLQT0dZR+
2014-04-20 05:12:25 UTC
Permalink
Yair Zaslavsky has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 1:

I am in favor of the idea.
I think that anything that can be stripped out so others may enjoy it is a good idea.
For example, in the past I have discussed with Eli to consider to make the database upgrade/installation a more "autonomous" framework.
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
yzaslavs-H+wXaHxf7aLQT0dZR+
2014-04-20 05:14:47 UTC
Permalink
Yair Zaslavsky has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/26924/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java
File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java:

Line 20: import org.ovirt.engine.core.common.config.ConfigValues;
Line 21: import org.ovirt.engine.core.utils.EngineLocalConfig;
Line 22: import org.ovirt.engine.core.uutils.ssh.OpenSSHUtils;
Line 23:
Line 24: public class EngineEncryptionUtils {
But what about this class? can't people benefit if it will be in uutils as well?
Line 25:
Line 26: private static final Log log = LogFactory.getLog(EngineEncryptionUtils.class);
Line 27:
Line 28: private static final File keystoreFile;
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
Alon Bar-Lev
2014-04-20 06:36:15 UTC
Permalink
Alon Bar-Lev has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/26924/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java
File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java:

Line 20: import org.ovirt.engine.core.common.config.ConfigValues;
Line 21: import org.ovirt.engine.core.utils.EngineLocalConfig;
Line 22: import org.ovirt.engine.core.uutils.ssh.OpenSSHUtils;
Line 23:
Line 24: public class EngineEncryptionUtils {
Post by yzaslavs-H+wXaHxf7aLQT0dZR+
But what about this class? can't people benefit if it will be in uutils as
this is *BAD* class, bad implementation, and specific for engine...
Line 25:
Line 26: private static final Log log = LogFactory.getLog(EngineEncryptionUtils.class);
Line 27:
Line 28: private static final File keystoreFile;
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
yzaslavs-H+wXaHxf7aLQT0dZR+
2014-04-20 11:49:23 UTC
Permalink
Yair Zaslavsky has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/26924/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java
File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java:

Line 20: import org.ovirt.engine.core.common.config.ConfigValues;
Line 21: import org.ovirt.engine.core.utils.EngineLocalConfig;
Line 22: import org.ovirt.engine.core.uutils.ssh.OpenSSHUtils;
Line 23:
Line 24: public class EngineEncryptionUtils {
Post by Alon Bar-Lev
this is *BAD* class, bad implementation, and specific for engine...
i know it is specific for engine due to EngineLocalConfig (for example).
Is there any point in doing some moderate refactoring here, and moving something to uutils? (sorry for not being clear before).
Line 25:
Line 26: private static final Log log = LogFactory.getLog(EngineEncryptionUtils.class);
Line 27:
Line 28: private static final File keystoreFile;
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
Alon Bar-Lev
2014-04-20 11:52:26 UTC
Permalink
Alon Bar-Lev has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/26924/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java
File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java:

Line 20: import org.ovirt.engine.core.common.config.ConfigValues;
Line 21: import org.ovirt.engine.core.utils.EngineLocalConfig;
Line 22: import org.ovirt.engine.core.uutils.ssh.OpenSSHUtils;
Line 23:
Line 24: public class EngineEncryptionUtils {
Post by yzaslavs-H+wXaHxf7aLQT0dZR+
i know it is specific for engine due to EngineLocalConfig (for example).
no... it is bad and invalid.

for example it uses PK for encryption instead of cipher, and other bad behaviours.

one day I will also remove this class.
Line 25:
Line 26: private static final Log log = LogFactory.getLog(EngineEncryptionUtils.class);
Line 27:
Line 28: private static final File keystoreFile;
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
yzaslavs-H+wXaHxf7aLQT0dZR+
2014-04-20 12:22:01 UTC
Permalink
Yair Zaslavsky has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 1:

(1 comment)

More candidates to consider -
a. ReflectionUtils
b. DnsSrvLocator (and maybe its subclasses as well).
c. EnumUtils

Thoughts?

http://gerrit.ovirt.org/#/c/26924/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java
File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java:

Line 20: import org.ovirt.engine.core.common.config.ConfigValues;
Line 21: import org.ovirt.engine.core.utils.EngineLocalConfig;
Line 22: import org.ovirt.engine.core.uutils.ssh.OpenSSHUtils;
Line 23:
Line 24: public class EngineEncryptionUtils {
Post by Alon Bar-Lev
no... it is bad and invalid.
ok
Line 25:
Line 26: private static final Log log = LogFactory.getLog(EngineEncryptionUtils.class);
Line 27:
Line 28: private static final File keystoreFile;
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
Alon Bar-Lev
2014-04-20 17:15:49 UTC
Permalink
Alon Bar-Lev has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 1:

ReflectionUtils - I do not see any reason to have this class, nor we should publish it anywhere... it is so trivial and used only 3 times, so it is not that usable (util).

DnsSrvLocator - used only by the ldap/kerberos should have been moved to there within last series of split.

EnumUtils - maybe worth look into... but... can you please explain why it is required? only to use case insensitive? why don't we use case sensitive and:

Enum1.valueOf("Entry")
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
Alon Bar-Lev
2014-04-20 17:55:50 UTC
Permalink
Alon Bar-Lev has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 1:

EnumUtils - why don't we sync names with vdsm... well this is too late... but why not hold enum values as UPPER CASE and just do:

Enum1.valueOf(value.toUpperCase())
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
Alon Bar-Lev
2014-04-20 18:24:54 UTC
Permalink
Alon Bar-Lev has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 1:

OK... while trying to move it to uutils, I saw that gwt also use this class in modified form... so not sure it can be moved at all, as ui should not use uutils.
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
yzaslavs-H+wXaHxf7aLQT0dZR+
2014-04-22 06:53:58 UTC
Permalink
Yair Zaslavsky has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 1:

ok, i gave this list from a quick glance at utils package.
we can advance if you think you added all packages here.
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-04-22 11:20:05 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
Alon Bar-Lev
2014-04-22 11:21:14 UTC
Permalink
Alon Bar-Lev has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 2:

Added LocalConfig which is now ShellLikeConfd
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-04-22 11:30:50 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/5977/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/22222/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-04-22 13:16:44 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-04-22 13:24:58 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/6001/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/22246/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
yzaslavs-H+wXaHxf7aLQT0dZR+
2014-04-26 03:09:59 UTC
Permalink
Yair Zaslavsky has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/26924/3/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java
File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java:

Line 21: import org.apache.commons.lang.StringUtils;
Line 22: import org.apache.commons.logging.Log;
Line 23: import org.apache.commons.logging.LogFactory;
Line 24:
Line 25: public class ShellLikeConfd {
What's the motivation behind the name?
Line 26: private static final Log log = LogFactory.getLog(ShellLikeConfd.class);
Line 27:
Line 28: private static final String SENSITIVE_KEYS = "SENSITIVE_KEYS";
Line 29:
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
Alon Bar-Lev
2014-04-26 07:27:05 UTC
Permalink
Alon Bar-Lev has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/26924/3/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java
File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java:

Line 21: import org.apache.commons.lang.StringUtils;
Line 22: import org.apache.commons.logging.Log;
Line 23: import org.apache.commons.logging.LogFactory;
Line 24:
Line 25: public class ShellLikeConfd {
Post by yzaslavs-H+wXaHxf7aLQT0dZR+
What's the motivation behind the name?
make it generic, it is not really related to ovirt nor engine.

the mission of uutils are utilities that can be used elsewhere as-is...
Line 26: private static final Log log = LogFactory.getLog(ShellLikeConfd.class);
Line 27:
Line 28: private static final String SENSITIVE_KEYS = "SENSITIVE_KEYS";
Line 29:
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
yzaslavs-H+wXaHxf7aLQT0dZR+
2014-04-26 07:29:02 UTC
Permalink
Yair Zaslavsky has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/26924/3/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java
File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java:

Line 21: import org.apache.commons.lang.StringUtils;
Line 22: import org.apache.commons.logging.Log;
Line 23: import org.apache.commons.logging.LogFactory;
Line 24:
Line 25: public class ShellLikeConfd {
Post by Alon Bar-Lev
make it generic, it is not really related to ovirt nor engine.
ok, but why SHellLike, and not just Configuration or something like that?
Line 26: private static final Log log = LogFactory.getLog(ShellLikeConfd.class);
Line 27:
Line 28: private static final String SENSITIVE_KEYS = "SENSITIVE_KEYS";
Line 29:
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
Alon Bar-Lev
2014-04-26 07:35:33 UTC
Permalink
Alon Bar-Lev has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/26924/3/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java
File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java:

Line 21: import org.apache.commons.lang.StringUtils;
Line 22: import org.apache.commons.logging.Log;
Line 23: import org.apache.commons.logging.LogFactory;
Line 24:
Line 25: public class ShellLikeConfd {
Post by yzaslavs-H+wXaHxf7aLQT0dZR+
ok, but why SHellLike, and not just Configuration or something like that?
because it is shell like...

# comment
XXX=value
XXX="${XXX}"
^^^^ no spaces, optional quotes
^^^^^ ${XXX} variables.
^^^^^ comments
Line 26: private static final Log log = LogFactory.getLog(ShellLikeConfd.class);
Line 27:
Line 28: private static final String SENSITIVE_KEYS = "SENSITIVE_KEYS";
Line 29:
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
yzaslavs-H+wXaHxf7aLQT0dZR+
2014-04-26 09:29:00 UTC
Permalink
Yair Zaslavsky has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
yzaslavs-H+wXaHxf7aLQT0dZR+
2014-04-26 09:38:56 UTC
Permalink
Yair Zaslavsky has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 3:

ok, do you want to add something else, or do you want to get this merged?
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
Alon Bar-Lev
2014-04-26 15:52:18 UTC
Permalink
Alon Bar-Lev has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................
Post by yzaslavs-H+wXaHxf7aLQT0dZR+
ok, do you want to add something else, or do you want to get this merged?
we can merge and add later if we do not have any immediate candidates.
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oourfali-H+wXaHxf7aLQT0dZR+
2014-04-27 06:42:31 UTC
Permalink
Oved Ourfali has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

minor comment on the name / javadoc / both.

http://gerrit.ovirt.org/#/c/26924/3/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java
File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java:

Line 21: import org.apache.commons.lang.StringUtils;
Line 22: import org.apache.commons.logging.Log;
Line 23: import org.apache.commons.logging.LogFactory;
Line 24:
Line 25: public class ShellLikeConfd {
Post by Alon Bar-Lev
because it is shell like...
I'd preferr calling it FileConfiguration, providing some java-doc to explain it.
(java-doc would be a good idea here anyway).
Line 26: private static final Log log = LogFactory.getLog(ShellLikeConfd.class);
Line 27:
Line 28: private static final String SENSITIVE_KEYS = "SENSITIVE_KEYS";
Line 29:
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
Alon Bar-Lev
2014-04-27 06:49:15 UTC
Permalink
Alon Bar-Lev has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/26924/3/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java
File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java:

Line 21: import org.apache.commons.lang.StringUtils;
Line 22: import org.apache.commons.logging.Log;
Line 23: import org.apache.commons.logging.LogFactory;
Line 24:
Line 25: public class ShellLikeConfd {
Post by oourfali-H+wXaHxf7aLQT0dZR+
I'd preferr calling it FileConfiguration, providing some java-doc to explai
See above discussion, it is not FileConfiguration, it is configuration for be read by shell as well using source.

Previous javadoc were just wrong, not sure what good in these but adding.
Line 26: private static final Log log = LogFactory.getLog(ShellLikeConfd.class);
Line 27:
Line 28: private static final String SENSITIVE_KEYS = "SENSITIVE_KEYS";
Line 29:
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
oourfali-H+wXaHxf7aLQT0dZR+
2014-04-27 06:50:30 UTC
Permalink
Oved Ourfali has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/26924/3/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java
File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java:

Line 21: import org.apache.commons.lang.StringUtils;
Line 22: import org.apache.commons.logging.Log;
Line 23: import org.apache.commons.logging.LogFactory;
Line 24:
Line 25: public class ShellLikeConfd {
Post by Alon Bar-Lev
See above discussion, it is not FileConfiguration, it is configuration for
Thank you.
Line 26: private static final Log log = LogFactory.getLog(ShellLikeConfd.class);
Line 27:
Line 28: private static final String SENSITIVE_KEYS = "SENSITIVE_KEYS";
Line 29:
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
a***@public.gmane.org
2014-04-27 06:55:33 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-04-27 07:06:03 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 4:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/5638/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/6332/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/22577/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
Alon Bar-Lev
2014-04-30 11:27:26 UTC
Permalink
Alon Bar-Lev has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 5:

rebase

anything more guys?
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oourfali-H+wXaHxf7aLQT0dZR+
2014-04-30 11:29:11 UTC
Permalink
Oved Ourfali has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-04-30 11:26:44 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
yzaslavs-H+wXaHxf7aLQT0dZR+
2014-04-30 11:33:25 UTC
Permalink
Yair Zaslavsky has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-04-30 11:42:48 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 5:

Build Failed

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/23014/ : There was an infra issue, please contact infra-***@public.gmane.org

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/6774/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/6080/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
Alon Bar-Lev
2014-04-30 12:03:18 UTC
Permalink
Alon Bar-Lev has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
yzaslavs-H+wXaHxf7aLQT0dZR+
2014-04-30 12:12:19 UTC
Permalink
Yair Zaslavsky has submitted this change and it was merged.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


utils: introduce universal utilities (uutils)

a package of packages that may be split out of engine, not directly
related to engine and can be split even to own jars.

this will enable components that should not pull the engine 'common'
part to enjoy these utilities.

Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Signed-off-by: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
---
M Makefile
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHClient.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHDialog.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java
M backend/manager/modules/builtin-extensions/pom.xml
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsArguments.java
M backend/manager/modules/builtin-extensions/src/main/modules/org/ovirt/engine/extensions/builtin/main/module.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/EngineLocalConfig.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java
M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml
A backend/manager/modules/uutils/exclude-filters.xml
A backend/manager/modules/uutils/pom.xml
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/Argument.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/ArgumentBuilder.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/ExtendedCliParser.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ConstraintByteArrayOutputStream.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressInputStream.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressOutputStream.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHClient.java
R backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHDialog.java
A backend/manager/modules/uutils/src/main/modules/org/ovirt/engine/core/uutils/main/module.xml
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/cli/ArgumentBuilderTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/cli/ExtendedCliParserTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/config/ShellLikeConfdTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/BasicTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/CommandTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/ConstraintByteArrayOutputStreamTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtilsTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/PropertiesTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHD.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHDialogTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TimeoutTest.java
R backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TransferTest.java
R backend/manager/modules/uutils/src/test/resources/config.conf
R backend/manager/modules/uutils/src/test/resources/config.conf.ref
A backend/manager/modules/uutils/src/test/resources/key.p12
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java
M backend/manager/tools/src/main/modules/org/ovirt/engine/core/tools/main/module.xml
M ear/src/main/resources/META-INF/MANIFEST.MF
M ovirt-engine.spec.in
49 files changed, 216 insertions(+), 79 deletions(-)

Approvals:
Alon Bar-Lev: Verified
Yair Zaslavsky: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
a***@public.gmane.org
2014-04-30 12:12:25 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED: IGNORE, no Bug-Url found.
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-04-30 17:59:45 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: utils: introduce universal utilities (uutils)
......................................................................


Patch Set 6:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/6980/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_merged/7315/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_animal-sniffer_merged/6550/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_merged/7650/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/26924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Alon Bar-Lev <alonbl-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
Loading...