Discussion:
Change in ovirt-engine[master]: core: Add numa node index when create vm numa node
(too old to reply)
a***@public.gmane.org
2014-05-26 09:03:04 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 2:

* #1099814::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-05-26 09:34:39 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8943/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/8260/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/25186/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-05-28 02:53:42 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 3:

* #1099814::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-05-28 03:11:51 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/9135/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/25379/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/8453/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
x***@public.gmane.org
2014-05-28 05:45:04 UTC
Permalink
Xiaolei Shi has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-06-04 06:54:38 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 4:

* #1099814::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
x***@public.gmane.org
2014-06-04 06:56:59 UTC
Permalink
Xiaolei Shi has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-06-04 07:29:40 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 4:

Build Failed

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/8997/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/9678/ : FAILURE

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/25892/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
gchaplik-H+wXaHxf7aLQT0dZR+
2014-06-04 09:43:02 UTC
Permalink
Gilad Chaplik has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
x***@public.gmane.org
2014-06-12 06:05:35 UTC
Permalink
Xiaolei Shi has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-06-12 06:17:46 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 5:

* Update tracker::#1099814::OK
* Check Bug-Url::OK
* Check Public Bug::#1099814::OK, public bug
* Check Product::#1099814::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-06-12 06:23:38 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 5:

Build Failed

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/9607/ : There was an infra issue, please contact infra-***@public.gmane.org

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/26501/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/10293/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
x***@public.gmane.org
2014-07-04 02:47:01 UTC
Permalink
Xiaolei Shi has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-07-15 06:44:59 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 7:

* Update tracker::#1099814::OK
* Check Bug-Url::OK
* Check Public Bug::#1099814::OK, public bug
* Check Product::#1099814::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-07-15 07:14:51 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 7:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/12486/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13157/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/29357/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-07-16 07:25:28 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 8:

* Update tracker::#1099814::OK
* Check Bug-Url::OK
* Check Public Bug::#1099814::OK, public bug
* Check Product::#1099814::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-07-16 07:49:35 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 9:

* Update tracker::#1099814::OK
* Check Bug-Url::OK
* Check Public Bug::#1099814::OK, public bug
* Check Product::#1099814::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
x***@public.gmane.org
2014-07-16 07:50:00 UTC
Permalink
Xiaolei Shi has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 9: Verified+1
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-07-16 08:45:09 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 8:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/12583/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13252/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/29452/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-07-16 09:11:59 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 9:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/12595/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13264/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/29464/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-07-21 04:55:49 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 10:

* Update tracker::#1099814::OK
* Check Bug-Url::OK
* Check Public Bug::#1099814::OK, public bug
* Check Product::#1099814::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-07-21 05:11:42 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 10:

Build Failed

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/12823/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13475/ : FAILURE

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/29675/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
rgolan-H+wXaHxf7aLQT0dZR+
2014-07-24 07:23:58 UTC
Permalink
Roy Golan has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 10: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-07-24 09:02:12 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 11:

* Update tracker::#1099814::OK
* Check Bug-Url::OK
* Check Public Bug::#1099814::OK, public bug
* Check Product::#1099814::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
x***@public.gmane.org
2014-07-24 09:04:13 UTC
Permalink
Xiaolei Shi has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 11: Verified+1

Rebased with the modified dependent patch.
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-07-24 09:34:59 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 11:

Build Failed

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/29980/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13780/ : FAILURE

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/13129/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
gchaplik-H+wXaHxf7aLQT0dZR+
2014-08-11 14:16:26 UTC
Permalink
Gilad Chaplik has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-14 14:25:10 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 12:

* Update tracker::#1099814::OK
* Check Bug-Url::OK
* Check Public Bug::#1099814::OK, public bug
* Check Product::#1099814::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-14 15:16:08 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 12:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16123/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/32930/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/16730/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-15 08:06:10 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 13:

* Update tracker::#1099814::OK
* Check Bug-Url::OK
* Check Public Bug::#1099814::OK, public bug
* Check Product::#1099814::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-15 08:51:33 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 13:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16169/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/32976/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/16776/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Doron Fediuck <dfediuck-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
rgolan-H+wXaHxf7aLQT0dZR+
2014-09-16 12:59:58 UTC
Permalink
Roy Golan has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 13: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/27988/13/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java
File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java:

Line 20: for (VmNumaNode node : vmNumaNodes) {
Line 21: Map<String, Object> createVmNumaNode = new HashMap<>();
Line 22: createVmNumaNode.put(VdsProperties.NUMA_NODE_CPU_LIST, NumaUtils.buildStringFromListForNuma(node.getCpuIds()));
Line 23: createVmNumaNode.put(VdsProperties.VM_NUMA_NODE_MEM, String.valueOf(node.getMemTotal()));
Line 24: createVmNumaNode.put(VdsProperties.NUMA_NODE_INDEX, node.getIndex());
* except for CPU,MEM,INDEX do we need to send something else with it?
* add a check in the NumaNodeFactoryTest
Line 25: createVmNumaNodes.add(createVmNumaNode);
Line 26: }
Line 27: return createVmNumaNodes;
Line 28: }
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Doron Fediuck <dfediuck-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
a***@public.gmane.org
2014-09-16 13:38:07 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 14:

* Update tracker::#1099814::OK
* Check Bug-Url::OK
* Check Public Bug::#1099814::OK, public bug
* Check Product::#1099814::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Doron Fediuck <dfediuck-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-16 14:41:17 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 14:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16350/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33156/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/16956/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Doron Fediuck <dfediuck-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-18 14:33:26 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 15:

* Update tracker::#1099814::OK
* Check Bug-Url::OK
* Check Public Bug::#1099814::OK, public bug
* Check Product::#1099814::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Doron Fediuck <dfediuck-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-18 15:26:54 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 15:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16484/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33289/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/17089/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Doron Fediuck <dfediuck-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
rgolan-H+wXaHxf7aLQT0dZR+
2014-09-22 06:07:44 UTC
Permalink
Roy Golan has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 15: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Doron Fediuck <dfediuck-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-22 06:57:18 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 16:

* Update tracker::#1099814::OK
* Check Bug-Url::OK
* Check Public Bug::#1099814::OK, public bug
* Check Product::#1099814::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Doron Fediuck <dfediuck-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
gchaplik-H+wXaHxf7aLQT0dZR+
2014-09-22 06:58:54 UTC
Permalink
Gilad Chaplik has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 16: Verified+1 Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Doron Fediuck <dfediuck-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-22 08:50:50 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 16:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16651/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33455/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/17255/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Doron Fediuck <dfediuck-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
a***@public.gmane.org
2014-09-22 08:50:57 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 17:

* Update tracker::#1099814::OK
* Check Bug-Url::OK
* Check Public Bug::#1099814::OK, public bug
* Check Product::#1099814::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Doron Fediuck <dfediuck-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
rgolan-H+wXaHxf7aLQT0dZR+
2014-09-22 08:50:56 UTC
Permalink
Roy Golan has submitted this change and it was merged.

Change subject: core: Add numa node index when create vm numa node
......................................................................


core: Add numa node index when create vm numa node

Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Bug-Url: https://bugzilla.redhat.com/1099814
Signed-off-by: Bruce Shi <xiao-lei.shi-***@public.gmane.org>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactoryTest.java
2 files changed, 3 insertions(+), 0 deletions(-)

Approvals:
Gilad Chaplik: Verified; Looks good to me, but someone else must approve
Roy Golan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Doron Fediuck <dfediuck-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
a***@public.gmane.org
2014-09-22 08:51:01 UTC
Permalink
automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 17:

* Update tracker::#1099814::OK
* Check TR::#1099814::ERROR, 3.5.0 should not match .*
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Doron Fediuck <dfediuck-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-22 09:25:22 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 17:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16670/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33474/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/17274/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Doron Fediuck <dfediuck-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
oVirt Jenkins CI Server
2014-09-22 09:38:18 UTC
Permalink
oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Add numa node index when create vm numa node
......................................................................


Patch Set 17:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_animal-sniffer_merged/8508/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_merged/9561/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_merged/9228/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_merged/4279/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/8886/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27988
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Doron Fediuck <dfediuck-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
Continue reading on narkive:
Loading...